Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Relationship popup window closes by itself when reverse the direction (#4735) #4954

Merged
merged 1 commit into from Nov 23, 2023
Merged

[frontend] Relationship popup window closes by itself when reverse the direction (#4735) #4954

merged 1 commit into from Nov 23, 2023

Conversation

SarahBocognano
Copy link
Member

@SarahBocognano SarahBocognano self-assigned this Nov 22, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9143ea0) 87.27% compared to head (39b6058) 87.27%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4954   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files           3        3           
  Lines         220      220           
  Branches       55       55           
=======================================
  Hits          192      192           
  Misses         28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn self-requested a review November 23, 2023 08:48
lndrtrbn
lndrtrbn approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit confused about not resetting the form when clicking cancel but it seems to work and not keeping the old state when opening again so 🤷‍♂️

@SarahBocognano SarahBocognano merged commit f0d7ba1 into master Nov 23, 2023
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/4735 branch November 25, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lndrtrbn lndrtrbn lndrtrbn approved these changes

@Kedae Kedae Awaiting requested review from Kedae

Assignees

@SarahBocognano SarahBocognano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SarahBocognano @lndrtrbn