Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix changing view in Knowledge (#4965) #4971

Merged
merged 1 commit into from Nov 23, 2023
Merged

Conversation

lndrtrbn
Copy link
Member

Proposed changes

  • A check was made before to ensure the value of the new view is valid, but in a recent commit this check was removed, add it again.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn
Copy link
Member Author

lndrtrbn commented Nov 23, 2023

Something is bothering me, even if this fix prevent from facing this issue again, if you already faced it it won't fix it as the issue corrupts the local storage with a null value. And so, even with this fix, your local storage still has a null value that leads you into a blank page.

You can have a look at EntityStixCoreRelationshipsIndicators.tsx to see why.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0d7ba1) 87.27% compared to head (01022db) 87.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4971   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files           3        3           
  Lines         220      220           
  Branches       55       55           
=======================================
  Hits          192      192           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit a1130db into master Nov 23, 2023
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/4965 branch November 23, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants