[frontend] Fix page group updated when adding users #4979
Conversation
| const membersData = data.group?.members; | ||
| return ( | ||
| <ListLinesContent | ||
| initialLoading={!data} | ||
| isLoading={isLoadingMore} | ||
| loadMore={loadMore} | ||
| hasMore={hasMore} | ||
| dataList={membersData?.edges ?? []} | ||
| dataList={groupData.edges ?? []} |
There was a problem hiding this comment.
You can't call groupData.edges and type groupData: string[], TypeScript won't be happy with that 👿
But more globally, I'm not sure this is the approach we want to fix the issue. By giving members in props you are bypassing Relay refetchable fragment defined in this file. Or if we want to do this that way, you need to remove query that is not used anymore in this file. @Kedae any sharing on this?
There was a problem hiding this comment.
Well, it's working but I think we can update the connection from an outside component. I'll check because I think we have done that for tasks. I'll get back to you.
There was a problem hiding this comment.
As discussed with @CelineSebe > We need to use insertNode and deleteNode but we need to find a way to propagate the paginationOptions
Related issues
#4930
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...