Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix ItemIcon type (#4933) #4980

Merged
merged 1 commit into from Nov 24, 2023
Merged

[frontend] Fix ItemIcon type (#4933) #4980

merged 1 commit into from Nov 24, 2023

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Nov 24, 2023

Proposed changes

  • <ItemIcon/> component had UserOverview type, which did not correspond to any type inside the component.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact self-assigned this Nov 24, 2023
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1130db) 87.27% compared to head (f786370) 87.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4980   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files           3        3           
  Lines         220      220           
  Branches       55       55           
=======================================
  Hits          192      192           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit 60e83b8 into master Nov 24, 2023
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/4933 branch November 24, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants