[backend/frontend] Improve auditing to split file read and file download (#5005)

[richard-julien]

See #5005

[lndrtrbn]

Can't we just have one function taking the scope download or read in parameter to avoid duplicates ? In a same way checkFileAccess has been made

Suggested change

	const publishFileDownload = async (executeContext, auth, file) => {
	const { filename, entity_id } = file.metaData;
	const entity = entity_id ? await internalLoadById(executeContext, auth, entity_id) : undefined;
	const data = buildContextDataForFile(entity, file.id, filename);
	await publishUserAction({
	user: auth,
	event_type: 'file',
	event_access: 'extended',
	event_scope: 'download',
	context_data: data
	});
	};
	const publishFile = async (executeContext, auth, file, event_scope) => {
	const { filename, entity_id } = file.metaData;
	const entity = entity_id ? await internalLoadById(executeContext, auth, entity_id) : undefined;
	const data = buildContextDataForFile(entity, file.id, filename);
	await publishUserAction({
	user: auth,
	event_type: 'file',
	event_access: 'extended',
	event_scope,
	context_data: data
	});
	};

[richard-julien]

Thanks for the comment. I will merge as it is and will be part of future refactor.