Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] improve global search layout (#1483) #5019

Merged
merged 6 commits into from Dec 1, 2023
Merged

[frontend] improve global search layout (#1483) #5019

merged 6 commits into from Dec 1, 2023

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Nov 30, 2023 •
edited

Proposed changes

  • Remove keyword from "Global search" title
  • Try to fix keyword in the top bar
  • Add file search counter badge

Related issues

Final PR with small fixes for :

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Nov 30, 2023
@SouadHadjiat SouadHadjiat marked this pull request as ready for review December 1, 2023 09:01
@SouadHadjiat SouadHadjiat merged commit ce58730 into master Dec 1, 2023
6 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/1483-4 branch December 1, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lndrtrbn lndrtrbn lndrtrbn approved these changes

Assignees

@SouadHadjiat SouadHadjiat

@marieflorescontact marieflorescontact

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SouadHadjiat @lndrtrbn @marieflorescontact