Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend/backend] restrict api filter keys to EQ operator and OR local mode (#5103) #5109

Merged
merged 33 commits into from
Dec 7, 2023
Merged

[frontend/backend] restrict api filter keys to EQ operator and OR local mode (#5103) #5109

merged 33 commits into from
Dec 7, 2023

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Dec 5, 2023 •
edited

PR content:

Only reviewed by the Filters Team !!!

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Dec 5, 2023
@Archidoit Archidoit marked this pull request as draft December 5, 2023 14:36
@Archidoit Archidoit linked an issue Dec 5, 2023 that may be closed by this pull request
On Threat, knowledge filter when using "not_equals" filter campaign, I should not have any campaign displayed #5103
Closed
@Archidoit
Copy link
Member Author

Archidoit commented Dec 5, 2023 •
edited

@jpkha the operator between Api filters should be AND (not working with OR)
image

Filters we can do:
(fromId = X or Y) AND (toId = A) AND (fromTypes = B) AND [ all the other filters ]

@Archidoit
Copy link
Member Author

Archidoit commented Dec 6, 2023 •
edited

Issue if api filters and classic filters:
image
-> do a OR between fromId and toId

image
-> do a AND between everything

--> seen with JPK and Laurent

@Archidoit Archidoit marked this pull request as ready for review December 7, 2023 10:43
@jpkha jpkha self-requested a review December 7, 2023 14:59
@Archidoit Archidoit merged commit 0f39d0e into master Dec 7, 2023
6 checks passed
@Archidoit Archidoit deleted the issue/5103 branch December 7, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkha jpkha jpkha approved these changes

@labo-flg labo-flg labo-flg approved these changes

Assignees

@jpkha jpkha

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On Threat, knowledge filter when using "not_equals" filter campaign, I should not have any campaign displayed
3 participants
@Archidoit @jpkha @labo-flg