-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend/Backend] Quick fixes for existing CSV Mapper (#4932) #5152
Conversation
6292159
to
b38fd41
Compare
a7037a0
to
a4f5f26
Compare
098dd3a
to
ebe45ff
Compare
wip |
d0a1dbb
to
cd8c231
Compare
137cb3a
to
2348c62
Compare
76eebf9
to
7084672
Compare
About the following issue (first bullet in Proposed Changes): when changing the entity type inside a representation bloc, the errors were not reset and kept the state of the previous entity. We needed to rework a bit how errors were managed inside the form. Initially they were managed using A next step would be to rework the form to create custom components for Representation blocs using the Formik API to fully integrate Formik errors system easily. Out of scope for our case right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We noticed some performance issues with the changes on form validation.
Once you add a dozen representation, try to update the name or add a new representation : this can take several seconds to update.
7297acd
to
4ca5e3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5152 +/- ##
===========================================
+ Coverage 0 65.59% +65.59%
===========================================
Files 0 472 +472
Lines 0 59142 +59142
Branches 0 4322 +4322
===========================================
+ Hits 0 38795 +38795
- Misses 0 20347 +20347 ☔ View full report in Codecov by Sentry. |
Proposed changes
Fix refresh validity status of required inputs when changing entity type=> Need to rework the code of the formRelated issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...