[frontend] switch translation key when relationship (#5142)

[lndrtrbn]

Proposed changes

• Condition to display entity or relationship translation

The way of checking it (hard coded array of relation names) is not very elegant but I don't see how to do it otherwise. Making a query just to determine if the name is from an entity or a relationship seemed not a good solution neither, maybe I'm wrong?

Related issues

• Missing translations in investigation screen in expand dialog #5142

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality

[lndrtrbn]

Open to suggestions if you have better idea to check in mind

[SouadHadjiat]

I'm not sure to understand how we can see relationships in the targets list.
The dialog displays targets on the left and relationships on the right, how can we have relationships on the left part ? @lndrtrbn

[lndrtrbn]

Because we can have relations targeting other relations

[SouadHadjiat]

is this list complete ? I can see we have a lot more in STIX_CORE_RELATIONSHIPS

[labo-flg]

could you get it from the schema ?

const { schema } = useAuth();
// ...
const relationshipsNames = schema.sros.map(({id, label }) => label)

Something like that I believe

[labo-flg]

see how it's done is useSearchEntities, we use the schema to get generate all possible options in the filter autocomplete

[lndrtrbn]

Ok I'll have a look thanks @labo-flg

[lndrtrbn]

Indeed, seems way better now