Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend/backend] handle entity_type filter in bookmark widgets (#5182) #5211

Merged
merged 4 commits into from
Dec 14, 2023
Merged

[frontend/backend] handle entity_type filter in bookmark widgets (#5182) #5211

merged 4 commits into from
Dec 14, 2023

Conversation

Archidoit
Copy link
Member

issue: #5182

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Dec 14, 2023
@Archidoit Archidoit self-assigned this Dec 14, 2023
@Archidoit Archidoit linked an issue Dec 14, 2023 that may be closed by this pull request
In the widget bookmark, we propose many options to filter but only entity-types are taken into account. #5182
Closed
@Archidoit Archidoit marked this pull request as draft December 14, 2023 11:12
@Archidoit Archidoit marked this pull request as ready for review December 14, 2023 12:12
marieflorescontact
marieflorescontact reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that you fix the bug for Bookmark edition but not for Bookmark creation 💐

@Archidoit Archidoit marked this pull request as draft December 14, 2023 14:46
@jpkha jpkha self-requested a review December 14, 2023 15:47
@jpkha jpkha marked this pull request as ready for review December 14, 2023 16:22
@Archidoit Archidoit marked this pull request as draft December 14, 2023 16:45
@Archidoit Archidoit marked this pull request as ready for review December 14, 2023 17:05
marieflorescontact
marieflorescontact approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested 👌

@Archidoit Archidoit merged commit 0e03085 into master Dec 14, 2023
6 checks passed
@Archidoit Archidoit deleted the issue/5182 branch December 14, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkha jpkha jpkha approved these changes

@marieflorescontact marieflorescontact marieflorescontact approved these changes

@labo-flg labo-flg Awaiting requested review from labo-flg

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the widget bookmark, we propose many options to filter but only entity-types are taken into account.
3 participants
@Archidoit @jpkha @marieflorescontact