Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix connectors sorting (#5173) #5237

Merged
merged 3 commits into from
Dec 19, 2023
Merged

[frontend] Fix connectors sorting (#5173) #5237

merged 3 commits into from
Dec 19, 2023

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Dec 15, 2023

Proposed changes

  • Refactor ConnectorsStatus to .ts
  • Fix sorting on message
  • Fix sorting on auto

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact changed the title [frontend] Remove sorting on message [frontend] Remove sorting on message (#5173) Dec 15, 2023
@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c5be0a) 65.60% compared to head (1321041) 65.60%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5237   +/-   ##
=======================================
  Coverage   65.60%   65.60%           
=======================================
  Files         472      472           
  Lines       59160    59160           
  Branches     4328     4328           
=======================================
  Hits        38811    38811           
  Misses      20349    20349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact marked this pull request as ready for review December 18, 2023 12:58
@marieflorescontact marieflorescontact self-assigned this Dec 18, 2023
@marieflorescontact marieflorescontact changed the title [frontend] Remove sorting on message (#5173) [frontend] Fix connectors sorting (#5173) Dec 18, 2023
@SamuelHassine SamuelHassine merged commit bd5ef1d into master Dec 19, 2023
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5173 branch December 19, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants