Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Invalidate empty CSV mappers (#4644) #5272

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Dec 20, 2023

Proposed changes

  • new error case for the CSV mapper validator: having no representations. 1) This is useless and should not be selectable for import, and 2) this will throw error on using it during an import
  • fix the CSV mapper create/edit form so that the TEST button is properly disabled when initial values are invalid

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

I added some unit tests for the validator, but they do not cover all the cases.

@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Dec 20, 2023
@labo-flg labo-flg self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a90cb0) 65.59% compared to head (7c293ef) 65.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5272      +/-   ##
==========================================
+ Coverage   65.59%   65.61%   +0.02%     
==========================================
  Files         472      472              
  Lines       59160    59165       +5     
  Branches     4327     4336       +9     
==========================================
+ Hits        38808    38824      +16     
+ Misses      20352    20341      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg merged commit 85b46be into master Dec 21, 2023
8 checks passed
@labo-flg labo-flg deleted the issue/4944 branch December 21, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants