Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Extract default value representative (#5348) #5349

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Jan 3, 2024

Proposed changes

  • extract default value representative, and fallback to id in any case

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jan 3, 2024
@SouadHadjiat SouadHadjiat linked an issue Jan 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1c36f0) 65.66% compared to head (f249d50) 65.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5349   +/-   ##
=======================================
  Coverage   65.66%   65.67%           
=======================================
  Files         475      475           
  Lines       59277    59277           
  Branches     4330     4325    -5     
=======================================
+ Hits        38926    38929    +3     
+ Misses      20351    20348    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat merged commit 25446eb into master Jan 3, 2024
8 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/5348 branch January 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error trying to set a default value for kill chain phases
3 participants