Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix bulk search no longer works (#5341) #5357

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Jan 3, 2024

Proposed changes

  • Change attribute_abstract

Related issues

This PR fixes the issue, but it seems that bulk search doesn't work well (doesn't return all expected results): incident and report for example.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Jan 3, 2024
@SouadHadjiat SouadHadjiat changed the title Bulk search no longer works(#5341) [backend] Fix bulk search no longer works (#5341) Jan 3, 2024
@CelineSebe CelineSebe changed the title [backend] Fix bulk search no longer works (#5341) [frontend] Fix bulk search no longer works (#5341) Jan 3, 2024
@CelineSebe CelineSebe linked an issue Jan 3, 2024 that may be closed by this pull request
@CelineSebe CelineSebe marked this pull request as ready for review January 3, 2024 17:01
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1345035) 65.56% compared to head (b9d8d04) 65.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5357   +/-   ##
=======================================
  Coverage   65.56%   65.57%           
=======================================
  Files         475      475           
  Lines       59428    59428           
  Branches     4327     4328    +1     
=======================================
+ Hits        38966    38968    +2     
+ Misses      20462    20460    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no more 500 errors on the browser console.

@CelineSebe CelineSebe self-assigned this Jan 4, 2024
@CelineSebe CelineSebe merged commit 792ada4 into master Jan 4, 2024
8 checks passed
@CelineSebe CelineSebe deleted the issue/5341 branch January 4, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk search no longer works
2 participants