-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] fix link resolution for file export (#5466) #5472
Conversation
opencti-platform/opencti-front/src/private/components/analyses/malware_analyses/Root.tsx
Show resolved
Hide resolved
...m/opencti-front/src/private/components/common/stix_domain_objects/StixDomainObjectHeader.jsx
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5472 +/- ##
=======================================
Coverage 66.24% 66.24%
=======================================
Files 508 508
Lines 59807 59807
Branches 4365 4366 +1
=======================================
+ Hits 39619 39622 +3
+ Misses 20188 20185 -3 ☔ View full report in Codecov by Sentry. |
b42d752
to
d189a00
Compare
There is still this one which should be
|
Also, about the uppercase fix, I think it's better to put the right entity_type with the right case, or change the method to put everything in lowercase and lowercase the type.
|
Yes you're right, let's use the right entity type, it makes much more sense. |
Proposed changes
StixDomainObjectHeader
have the right entity type setRelated issues
Checklist
Further comments
To test, go to a Country knowledge view > export (any format) and hit Create. You should properly redirected to the entity's data tab.