Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix default value displayed in case of windows registry key (#5387) #5496

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

lndrtrbn
Copy link
Member

Proposed changes

  • manage the case of windows registry key when retrieving displayable value

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Jan 15, 2024
@lndrtrbn lndrtrbn linked an issue Jan 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6050df4) 66.24% compared to head (7f81e46) 66.24%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5496   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files         508      508           
  Lines       59807    59807           
  Branches     4365     4365           
=======================================
+ Hits        39619    39620    +1     
+ Misses      20188    20187    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit 758049b into master Jan 15, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5387 branch January 15, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value of a Registry Key is not properly shown in Workbench
3 participants