Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] extends Audits context filters to Knowledge events (#5611) #5613

Merged
merged 10 commits into from
Feb 17, 2024
Merged

[backend] extends Audits context filters to Knowledge events (#5611) #5613

merged 10 commits into from
Feb 17, 2024

Conversation

Archidoit
Copy link
Member

issue: #5611

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Jan 19, 2024
@Archidoit Archidoit self-assigned this Jan 19, 2024
@Archidoit Archidoit changed the title [backend] refacto completeContextDataForEntity (#5611) [backend] fix context filters in Audits (#5611) Jan 19, 2024
@Archidoit Archidoit marked this pull request as draft January 19, 2024 14:07
@Archidoit Archidoit linked an issue Jan 19, 2024 that may be closed by this pull request
Context label filtering in Audit only filters read events #5611
Closed
@Archidoit Archidoit changed the title [backend] fix context filters in Audits (#5611) [backend] extends Audits context filters to Knowledge (#5611) Jan 19, 2024
@Archidoit Archidoit marked this pull request as ready for review January 19, 2024 15:41
@Archidoit Archidoit marked this pull request as draft January 19, 2024 15:44
@Archidoit
Copy link
Member Author

Archidoit commented Jan 19, 2024 •
edited

ready for review, but need check with Julien before merge

@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (dbec2df) 65.68% compared to head (9ee3e5a) 65.71%.

Files Patch % Lines
...form/opencti-graphql/src/manager/historyManager.ts 0.00% 5 Missing ⚠️
...pencti-platform/opencti-graphql/src/domain/file.js 33.33% 2 Missing ⚠️
...tform/opencti-graphql/src/domain/stixCoreObject.js 50.00% 2 Missing ⚠️
...latform/opencti-graphql/src/types/stix-common.d.ts 0.00% 2 Missing ⚠️
...pencti-platform/opencti-graphql/src/domain/stix.js 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5613      +/-   ##
==========================================
+ Coverage   65.68%   65.71%   +0.03%     
==========================================
  Files         539      539              
  Lines       63570    63482      -88     
  Branches     5128     5131       +3     
==========================================
- Hits        41754    41718      -36     
+ Misses      21816    21764      -52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit marked this pull request as ready for review January 22, 2024 08:27
@Archidoit Archidoit changed the title [backend] extends Audits context filters to Knowledge (#5611) [backend] extends Audits context filters to Knowledge events (#5611) Jan 22, 2024
@Archidoit Archidoit force-pushed the issue/5611 branch 2 times, most recently from 5060045 to dec215d Compare January 31, 2024 14:30
@jpkha jpkha self-requested a review February 5, 2024 07:55
@jpkha
Copy link
Member

jpkha commented Feb 7, 2024

LGTM, I am letting @richard-julien to finalize the review

@richard-julien richard-julien merged commit 888a5e0 into master Feb 17, 2024
8 checks passed
@richard-julien richard-julien deleted the issue/5611 branch February 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkha jpkha jpkha left review comments

@richard-julien richard-julien Awaiting requested review from richard-julien

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context label filtering in Audit only filters read events
3 participants
@Archidoit @jpkha @richard-julien