[backend] manage long text filter like description and add search operator #4940 #5633

jpkha · 2024-01-22T14:31:12Z

jpkha · 2024-01-22T14:44:43Z

starts_with and ends_with work like contains . The nil operator does not work for an empty string "", for example. We should consider it as empty, but Elasticsearch checks if the field exists only.

codecov · 2024-01-22T15:15:01Z

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e915e33) 65.44% compared to head (6f9ef98) 65.49%.
Report is 3 commits behind head on master.

Files	Patch %	Lines
...ti-platform/opencti-graphql/src/database/engine.js	83.51%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5633      +/-   ##
==========================================
+ Coverage   65.44%   65.49%   +0.05%     
==========================================
  Files         539      539              
  Lines       63063    63179     +116     
  Branches     5050     5075      +25     
==========================================
+ Hits        41271    41382     +111     
- Misses      21792    21797       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jpkha · 2024-02-09T15:42:23Z

!missing test to do

Archidoit · 2024-02-12T10:54:15Z

opencti-platform/opencti-graphql/tests/02-integration/01-database/filterGroup-test.js

+        filters: {
+          mode: 'and',
+          filters: [{
+            key: ['description'],


array not required, in the front, we rather write: "key: 'description'"

Archidoit · 2024-02-12T10:54:24Z

opencti-platform/opencti-graphql/tests/02-integration/01-database/filterGroup-test.js

+        filters: {
+          mode: 'and',
+          filters: [{
+            key: ['description'],


same here and below

Goumies · 2024-02-15T11:26:55Z

opencti-platform/opencti-graphql/tests/02-integration/01-database/filterGroup-test.js

+    expect(queryResult.data.reports.edges.length).toEqual(1);
+  });
+
+  it('should find entities according to search filters on short string unorder', async () => {


Can you complete the test title with "unordered", if that was the intent ?

Yes sure. I put unorder but I think I am not grammatically correct sorry.

Goumies · 2024-02-15T11:46:28Z

I have noticed that the description and name options in the Add filter dropdown menu are the only ones in lowercase.
Can you capitalize it?

jpkha · 2024-02-15T12:50:27Z

I have noticed that the description and name options in the Add filter dropdown menu are the only ones in lowercase. Can you capitalize it?

I fixed it from the translation. Looks like in the other language we already put an upper case by default.

Archidoit · 2024-02-15T13:02:28Z

I have noticed that the description and name options in the Add filter dropdown menu are the only ones in lowercase. Can you capitalize it?

I fixed it from the translation. Looks like in the other language we already put an upper case by default.

It will be fixed in 4939 where we fetch labels from the back anyway. It's not so good to translate something without a first letter in upper case with something in upper case I think.

Archidoit · 2024-02-15T14:26:17Z

opencti-platform/opencti-front/lang/front/en.json

@@ -2163,7 +2163,7 @@
  "Level": "Level",
  "color": "color",
  "Force now": "Force now",
-  "name": "name",
+  "name": "Name",


I don't think name should be translated to Name because it changes the case. (Knowing that the 'name' and 'description' label will be ok in 4939

…rator #4940 (#5633)

jpkha marked this pull request as draft January 22, 2024 14:31

jpkha force-pushed the issue/4940 branch from 96bdbe7 to 2e6a2a6 Compare January 22, 2024 14:38

richard-julien added the filigran team use to identify PR from the Filigran team label Jan 22, 2024

jpkha force-pushed the issue/4940 branch 6 times, most recently from 4767fa0 to 4e54fc1 Compare January 29, 2024 10:30

jpkha force-pushed the issue/4940 branch from 4e54fc1 to add7707 Compare February 1, 2024 10:51

SamuelHassine force-pushed the master branch 4 times, most recently from 3972324 to 3d01224 Compare February 4, 2024 22:22

jpkha force-pushed the issue/4940 branch 2 times, most recently from 00fc190 to 539cfea Compare February 6, 2024 13:13

SamuelHassine force-pushed the master branch 2 times, most recently from 6f29a12 to ebfecd0 Compare February 9, 2024 01:54

jpkha force-pushed the issue/4940 branch from 539cfea to 10d89b3 Compare February 9, 2024 07:45

Archidoit linked an issue Feb 9, 2024 that may be closed by this pull request

Add a "contains" / "do not contains" operator in new filter #4940

Closed

jpkha marked this pull request as ready for review February 9, 2024 15:40

jpkha changed the title ~~[backend] manage long text filter like description~~ [backend] manage long text filter like description #4940 Feb 12, 2024

jpkha force-pushed the issue/4940 branch from 4773a69 to 1a718a6 Compare February 12, 2024 10:08

jpkha requested a review from Archidoit February 12, 2024 10:09

Archidoit reviewed Feb 12, 2024

View reviewed changes

jpkha requested a review from Archidoit February 13, 2024 13:08

jpkha force-pushed the issue/4940 branch from a7c8c17 to 302f47d Compare February 13, 2024 13:10

jpkha force-pushed the issue/4940 branch from f7c542d to 99a18ac Compare February 15, 2024 10:48

jpkha requested a review from Archidoit February 15, 2024 11:10

Goumies self-requested a review February 15, 2024 11:14

Goumies reviewed Feb 15, 2024

View reviewed changes

jpkha added 16 commits February 15, 2024 15:24

[backend] manage long text filter like description

6e5b0cf

[backend] manage empty string for nil and not_nil

850ef57

[frontend] create specific filter case for longFilter

983f339

[frontend] Add search in description filter

5e06568

[frontend/backend] add search query

220b8d7

[backend] use wildcard to find empty string

59ca135

[backend] remove file

993e0e8

[backend] remove file

a4cc300

[backend] push modification

f50f186

[backend] refactor code

faba959

[backend] Add search test

41891ad

[backend] fix test

26a01e3

[frontend] remove eq, not_eq, nil, not_nil from longText filter

bfd3c03

[backend] add more test

755df1a

[backend] fix test

f5c23d4

[frontend] fix translation

0b000b2

Archidoit reviewed Feb 15, 2024

View reviewed changes

[frontend] fix

6f9ef98

jpkha force-pushed the issue/4940 branch from e508805 to 6f9ef98 Compare February 15, 2024 14:28

Archidoit approved these changes Feb 15, 2024

View reviewed changes

jpkha merged commit 63053fa into master Feb 15, 2024
8 checks passed

SamuelHassine deleted the issue/4940 branch February 16, 2024 15:35

Archidoit pushed a commit that referenced this pull request Jun 6, 2024

[backend] manage long text filter like description and add search ope…

d8fc6fb

…rator #4940 (#5633)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[backend] manage long text filter like description and add search operator #4940 #5633

[backend] manage long text filter like description and add search operator #4940 #5633

jpkha commented Jan 22, 2024

jpkha commented Jan 22, 2024

codecov bot commented Jan 22, 2024 •

edited

jpkha commented Feb 9, 2024

Archidoit Feb 12, 2024

Archidoit Feb 12, 2024 •

edited

Goumies Feb 15, 2024

jpkha Feb 15, 2024

Goumies commented Feb 15, 2024

jpkha commented Feb 15, 2024

Archidoit commented Feb 15, 2024

Archidoit Feb 15, 2024

[backend] manage long text filter like description and add search operator #4940 #5633

[backend] manage long text filter like description and add search operator #4940 #5633

Conversation

jpkha commented Jan 22, 2024

jpkha commented Jan 22, 2024

codecov bot commented Jan 22, 2024 • edited

Codecov Report

jpkha commented Feb 9, 2024

Archidoit Feb 12, 2024

Choose a reason for hiding this comment

Archidoit Feb 12, 2024 • edited

Choose a reason for hiding this comment

Goumies Feb 15, 2024

Choose a reason for hiding this comment

jpkha Feb 15, 2024

Choose a reason for hiding this comment

Goumies commented Feb 15, 2024

jpkha commented Feb 15, 2024

Archidoit commented Feb 15, 2024

Archidoit Feb 15, 2024

Choose a reason for hiding this comment

codecov bot commented Jan 22, 2024 •

edited

Archidoit Feb 12, 2024 •

edited