[backend] Decay rules settings (#2859) #5641

SouadHadjiat · 2024-01-22T17:35:03Z

Proposed changes

Create a new module for decay rules
Initialize built-in decay rules (3 decay rules saved at init => update counters in tests + 3)
Save decay rules in cache
Apply saved decay rules (from cache) on indicators
List and display decay rules in settings
Add a form to create decay rules
generic tsx use for both chart (on settings and on indicator overview)
View and edit decay rule => + chart to visualize decay rule
Delete decay rules from settings
Reset decay computations when an indicator has an upsert on score or a score update (except if score = base score).
Add a simple visualization in graph for past decay data (when decay has been reset because of upsert or update).
Remove feature flag

Related issues

Decay settings for Indicators scores #2859

Checklist

I consider the submitted work as finished
I tested the code for its functionality
I wrote test cases for the relevant uses case
I added/update the relevant documentation (either on github or on notion)
Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov · 2024-01-22T18:07:58Z

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (87cf4bb) 64.99% compared to head (21cd376) 65.41%.

Files	Patch %	Lines
...-graphql/src/modules/indicator/indicator-domain.ts	75.47%	26 Missing ⚠️
...-graphql/src/modules/decayRule/decayRule-domain.ts	93.92%	24 Missing ⚠️
...aphql/src/modules/decayRule/decayRule-converter.ts	28.00%	18 Missing ⚠️
opencti-platform/opencti-graphql/src/managers.js	0.00%	12 Missing ⚠️
...tform/opencti-graphql/src/manager/managerModule.ts	22.22%	7 Missing ⚠️
...tform/opencti-graphql/src/domain/internalObject.ts	37.50%	5 Missing ⚠️
...pencti-graphql/src/database/data-initialization.js	0.00%	2 Missing ⚠️
...latform/opencti-graphql/src/database/middleware.js	85.71%	2 Missing ⚠️
...cti-platform/opencti-graphql/src/initialization.js	0.00%	2 Missing ⚠️
...opencti-graphql/src/modules/decayRule/decayRule.ts	94.73%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5641      +/-   ##
==========================================
+ Coverage   64.99%   65.41%   +0.41%     
==========================================
  Files         528      532       +4     
  Lines       62005    62501     +496     
  Branches     4967     5029      +62     
==========================================
+ Hits        40302    40886     +584     
+ Misses      21703    21615      -88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aHenryJard · 2024-02-09T08:00:07Z

opencti-platform/opencti-front/lang/front/en.json

-  "To use this feature, your platform administrator must enable the subscription manager in the config.": "To use this feature, your platform administrator must enable the subscription manager in the config.",
-  "To use this feature, your platform administrator must enable the according manager in the config.": "To use this feature, your platform administrator must enable the according manager in the config.",
+  "To use this feature, your platform administrator must enable the subscription manager in the config.": "To use this feature, your platform administrator must enable the subscription manager in configuration.",
+  "To use this feature, your platform administrator must enable the according manager in the config.": "To use this feature, your platform administrator must enable the according manager in configuration.",


In all other language "configuration" seems to be whole word.

aHenryJard · 2024-02-09T08:07:19Z

opencti-platform/opencti-graphql/tests/03-streams/00-Raw/raw-test.js

@@ -23,13 +23,13 @@ describe('Raw streams tests', () => {
      expect(createEventsByTypes.label.length).toBe(15);
      expect(createEventsByTypes.identity.length).toBe(30);
      expect(createEventsByTypes.relationship.length).toBe(126);
-      expect(createEventsByTypes.indicator.length).toBe(31);
+      expect(createEventsByTypes.indicator.length).toBe(33);


DecayRule integration test creates 2 indicators, so this is legit to me (same for others +2).

opencti-platform/opencti-front/src/components/i18n.jsx

jpkha · 2024-02-12T15:45:05Z

opencti-platform/opencti-front/src/private/components/observations/indicators/DecayDialog.tsx

  };

-  const decayFullHistory: LabelledDecayHistory[] = [];
+  const labelledHistoryList: LabelledDecayHistory[] = [];
  decayHistory.map((history) => (


const labelledHistoryList = [...decayHistory, ...decayLivePoints].map(history => getDisplayFor(history))

opencti-platform/opencti-front/src/private/components/settings/Root.jsx

lndrtrbn · 2024-02-12T15:47:35Z

opencti-platform/opencti-front/src/private/components/settings/decay/DecayRule.tsx

+import CustomizationMenu from '../CustomizationMenu';
+import { DecayRule_decayRule$key } from './__generated__/DecayRule_decayRule.graphql';
+
+const useStyles = makeStyles(() => ({
