Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] improve the readability of connector names (#3154) #5707

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Jan 26, 2024

Proposed changes

Improve the readability of connector names.

  • Display fullname (before : only 40 characters).

Related issues

issue #3154

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • I had to recreate sub-types that had not been individually generated by relay, with potentially null management.
    If you'd like more information, or if you've already encountered this problem and have a better solution, let me know.

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Jan 26, 2024
@frapuks frapuks force-pushed the issue/3154 branch 2 times, most recently from 94025b3 to f412644 Compare January 29, 2024 09:35
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45aabee) 64.76% compared to head (b0360e4) 64.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5707   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files         516      516           
  Lines       60973    60973           
  Branches     4871     4871           
=======================================
  Hits        39489    39489           
  Misses      21484    21484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks
Copy link
Member Author

frapuks commented Jan 30, 2024

ready for a 2nd round of reviews

@frapuks frapuks requested a review from Kedae January 30, 2024 09:27
Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the uncanny graphql typing with abusive null, I'm ok for these changes.
Now, if we want to revise the graphql API, this can be as easy as adding a bunch of !, but we need to check the implem backend side never sends null for real

@frapuks frapuks dismissed lndrtrbn’s stale review February 1, 2024 10:31

ok with Landry for dismiss to save time

@frapuks frapuks merged commit 4c91a7f into master Feb 1, 2024
8 checks passed
@frapuks frapuks self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants