-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] improve the readability of connector names (#3154) #5707
Conversation
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
94025b3
to
f412644
Compare
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-front/src/private/components/data/connectors/ConnectorWorks.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5707 +/- ##
=======================================
Coverage 64.76% 64.76%
=======================================
Files 516 516
Lines 60973 60973
Branches 4871 4871
=======================================
Hits 39489 39489
Misses 21484 21484 ☔ View full report in Codecov by Sentry. |
ready for a 2nd round of reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the uncanny graphql typing with abusive null, I'm ok for these changes.
Now, if we want to revise the graphql API, this can be as easy as adding a bunch of !
, but we need to check the implem backend side never sends null for real
ok with Landry for dismiss to save time
Proposed changes
Improve the readability of connector names.
Related issues
issue #3154
Checklist
Further comments
If you'd like more information, or if you've already encountered this problem and have a better solution, let me know.