Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes code coverage (all credits to @richard-julien 🙌)
The plugin
vitestMigrationPlugin
was turning the global pattern*.js
indatabase/migration.js
into real JS code, introducing several lines into the code. However, the resulting source mapping was not updated.This introduced a shift in the code base as displayed in the coverage reports.
We are not testing migrations scripts, so we can safely turn of this plugin. This meant refactoring the initialization phase so that vitest won't ever import
migration.js
during test setup.I've added a small change to the test base to check for coverage improvement, and reporting on the right lines of code.
This is working properly: