Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Invalid TAXII header when collection is exposed to public #5755

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Jan 31, 2024

Proposed changes

  • Set header with mediat type application/taxii+json to be aligned with STIX 2.1 standard

image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Expected output
image

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Jan 31, 2024
@helene-nguyen helene-nguyen self-assigned this Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (3153001) 64.72% compared to head (04dc9a1) 64.71%.
Report is 1 commits behind head on master.

❗ Current head 04dc9a1 differs from pull request most recent head f1d0753. Consider uploading reports for the commit f1d0753 to get more accurate results

Files Patch % Lines
...cti-platform/opencti-graphql/src/http/httpTaxii.js 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5755      +/-   ##
==========================================
- Coverage   64.72%   64.71%   -0.01%     
==========================================
  Files         516      516              
  Lines       60890    60894       +4     
  Branches     4855     4856       +1     
==========================================
  Hits        39410    39410              
- Misses      21480    21484       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richard-julien richard-julien changed the title [backend] Fix header to be aligned with STIX standard [backend] Invalid TAXII header when collection is exposed to public Jan 31, 2024
@richard-julien richard-julien merged commit 212bd5c into master Jan 31, 2024
4 of 6 checks passed
@richard-julien richard-julien deleted the issue/5621-fix branch January 31, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backend] Invalid TAXII header when collection is exposed to public
2 participants