Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix schema of StixFile where obsContent was also in schema attributes (#5751) #5758

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

lndrtrbn
Copy link
Member

Proposed changes

  • Remove obsContent from schema attributes and keep it only in schema refs

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

In my opinion there is also an issue when we want to add Artifacts to a File but I don't think it should be fixed in this issue.

@lndrtrbn lndrtrbn linked an issue Jan 31, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dfddbf) 64.72% compared to head (98e541d) 64.72%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5758      +/-   ##
==========================================
- Coverage   64.72%   64.72%   -0.01%     
==========================================
  Files         516      516              
  Lines       60890    60889       -1     
  Branches     4856     4856              
==========================================
- Hits        39410    39409       -1     
  Misses      21480    21480              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit cd68781 into master Jan 31, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5751 branch January 31, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV mapper configuration can mix up entity types fields
2 participants