Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix mailer / sending emails in the platform #5780

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

SamuelHassine
Copy link
Member

Proposed changes

[backend] Fix mailer / sending emails in the platform

Related issues

@SamuelHassine
Copy link
Member Author

Sending email through testing is ok, but sending through normal notification behavior don't....

@SamuelHassine SamuelHassine marked this pull request as draft February 1, 2024 10:28
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8c0f5c8) 64.76% compared to head (0c46db8) 64.76%.
Report is 3 commits behind head on master.

❗ Current head 0c46db8 differs from pull request most recent head c0f8bd1. Consider uploading reports for the commit c0f8bd1 to get more accurate results

Files Patch % Lines
...rm/opencti-graphql/src/manager/publisherManager.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5780   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files         516      516           
  Lines       60973    60973           
  Branches     4870     4870           
=======================================
  Hits        39489    39489           
  Misses      21484    21484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kedae Kedae force-pushed the issue/5773 branch 2 times, most recently from 91b4fbc to 0c46db8 Compare February 1, 2024 12:40
@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Feb 1, 2024
@SamuelHassine SamuelHassine marked this pull request as ready for review February 1, 2024 14:41
@SamuelHassine SamuelHassine merged commit 38c84ef into master Feb 1, 2024
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the issue/5773 branch February 1, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple mailer does not work anymore (testing or notification based)
2 participants