Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] improve the readability of connector names (#3154) #5785

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Feb 1, 2024

UPDATE

Prevent long name whitout whitespace
re-Add Tooltip
Reorganize Grid to make space in leftSide to displaying maximum of chars.

@frapuks frapuks force-pushed the issue/3154 branch 2 times, most recently from d255d65 to 69d300e Compare February 2, 2024 07:08
@frapuks
Copy link
Member Author

frapuks commented Feb 2, 2024

Final result, which takes care of names that are too long and without spaces, and redistributes Grid values to give more space to the name.
We can't reduce the spaces any more, otherwise end-dates might be on 2 lines, and/or the progress bar might overlap the button.
image

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (057ce97) 64.99% compared to head (fcace69) 64.99%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5785   +/-   ##
=======================================
  Coverage   64.99%   64.99%           
=======================================
  Files         521      521           
  Lines       61367    61367           
  Branches     4933     4933           
=======================================
  Hits        39887    39887           
  Misses      21480    21480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Feb 5, 2024
@frapuks frapuks merged commit 904edd0 into master Feb 5, 2024
8 checks passed
@frapuks frapuks added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 5, 2024
@SamuelHassine SamuelHassine deleted the issue/3154 branch February 13, 2024 12:28
@frapuks frapuks self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants