Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Refactor aws sdk to use the standard approach of the readme #5791

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

richard-julien
Copy link
Member

Try to align the way to log in with IAM following the README.

We need to find a way to test that in AWS.

@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Feb 1, 2024
@richard-julien richard-julien self-assigned this Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8d9fb1b) 64.82% compared to head (9673df1) 64.81%.
Report is 1 commits behind head on master.

❗ Current head 9673df1 differs from pull request most recent head 0091fa3. Consider uploading reports for the commit 0091fa3 to get more accurate results

Files Patch % Lines
...tform/opencti-graphql/src/database/file-storage.js 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5791      +/-   ##
==========================================
- Coverage   64.82%   64.81%   -0.02%     
==========================================
  Files         521      521              
  Lines       61359    61347      -12     
  Branches     4903     4900       -3     
==========================================
- Hits        39778    39762      -16     
- Misses      21581    21585       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit e133e21 into master Feb 2, 2024
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the oob/s3_iam branch February 2, 2024 06:54
@SamuelHassine SamuelHassine restored the oob/s3_iam branch February 2, 2024 06:55
SamuelHassine added a commit that referenced this pull request Feb 2, 2024
…#5791)

Co-authored-by: Samuel Hassine <samuel.hassine@filigran.io>
frapuks pushed a commit that referenced this pull request Feb 5, 2024
…#5791)

Co-authored-by: Samuel Hassine <samuel.hassine@filigran.io>
@SamuelHassine SamuelHassine deleted the oob/s3_iam branch February 13, 2024 12:27
@Kedae Kedae modified the milestone: Release 5.12.30 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants