Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Add "From/To" attributes ref in sightings relationships(#5814) #5821

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Feb 5, 2024

Proposed changes

  • [backend] add a method isStixSightingRelationship
  • [frontend] all entities are able to be in a sighting relationship (permisssive option)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CelineSebe CelineSebe linked an issue Feb 5, 2024 that may be closed by this pull request
@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Feb 5, 2024
@CelineSebe CelineSebe self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (49ecb64) 65.44% compared to head (6ad3284) 65.44%.

Files Patch % Lines
...src/modules/internal/csvMapper/csvMapper-domain.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5821   +/-   ##
=======================================
  Coverage   65.44%   65.44%           
=======================================
  Files         539      539           
  Lines       63051    63055    +4     
  Branches     5052     5053    +1     
=======================================
+ Hits        41264    41269    +5     
+ Misses      21787    21786    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe marked this pull request as draft February 6, 2024 10:02
@CelineSebe CelineSebe marked this pull request as ready for review February 13, 2024 10:35
Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sighting relationships can link every entities between them?

@CelineSebe CelineSebe changed the title [backend] Add "From/To" attributes ref in csv mapper relationships(#5814) [backend/frontend] Add "From/To" attributes ref in csv mapper relationships(#5814) Feb 13, 2024
@CelineSebe
Copy link
Member Author

CelineSebe commented Feb 13, 2024

So sighting relationships can link every entities between them?

For now, here and elsewhere on the plateform, can link every entities between them. The notion of sighting is expanded compared to the stix standards

@CelineSebe CelineSebe changed the title [backend/frontend] Add "From/To" attributes ref in csv mapper relationships(#5814) [backend/frontend] Add "From/To" attributes ref in sightings relationships(#5814) Feb 13, 2024
Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to add a relationship in the CSV mapper I have no attribute listed

image

@CelineSebe CelineSebe merged commit 770fd63 into master Feb 14, 2024
8 checks passed
@CelineSebe CelineSebe deleted the issue/5814 branch February 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sightings" attributes in csv mapper relationships are missing
2 participants