[backend] add test coverage on indicator upsert issue (#5819). #5846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aHenryJard
force-pushed
the
issues/5819-test-coverage
branch
from
42ff338
to
a6c094c
Compare
aHenryJard
commented
Feb 7, 2024
| input: { | ||
| toId: 'marking-definition--78ca4366-f5b8-4764-83f7-34ce38198e27', | ||
| toId: MARKING_TLP_GREEN, |
There was a problem hiding this comment.
This change on marking is done to make indicator-test run in standalone.
aHenryJard
force-pushed
the
issues/5819-test-coverage
branch
from
2da2d16
to
1e818ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5846 +/- ##
=======================================
Coverage 65.02% 65.02%
=======================================
Files 523 523
Lines 61449 61449
Branches 4942 4944 +2
=======================================
Hits 39959 39959
Misses 21490 21490 ☔ View full report in Codecov by Sentry. |
labo-flg
reviewed
Feb 8, 2024
| expect(queryResult.data?.indicators.edges.length).toEqual(4); | ||
| const indicatorList: [] = queryResult.data?.indicators.edges; | ||
| expect(indicatorList).toBeDefined(); | ||
| if (indicatorList) { |
There was a problem hiding this comment.
I suggest you do not check this ; you already expect it to be defined earlier so the test will fail explicitly.
it makes the code base more straightforward (dumb and simple I might say).
There was a problem hiding this comment.
deepscan is asking me to check it or it fails, maybe I'm missing something.... it seems that the expect is not enough
labo-flg
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...