Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Rename data sharing capability description (#5831) #5847

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Feb 7, 2024

Proposed changes

  • renaming :
  • Access data sharing => Access data sharing & ingestion
  • Manage data sharing => Manage data sharing & ingestion
  • migration for older plateform
  • doc PR

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact marked this pull request as ready for review February 7, 2024 11:01
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9ee0318) 65.02% compared to head (add9a8c) 65.10%.
Report is 15 commits behind head on master.

Files Patch % Lines
...pencti-graphql/src/database/data-initialization.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5847      +/-   ##
==========================================
+ Coverage   65.02%   65.10%   +0.07%     
==========================================
  Files         523      528       +5     
  Lines       61449    62003     +554     
  Branches     4942     5119     +177     
==========================================
+ Hits        39959    40365     +406     
- Misses      21490    21638     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact self-assigned this Feb 7, 2024
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Feb 7, 2024
@marieflorescontact marieflorescontact merged commit 9fefe42 into master Feb 9, 2024
8 checks passed
@marieflorescontact marieflorescontact deleted the issue/5831 branch February 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants