Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] restrict entity_type filter options to Containers in the Analyses tab (5850) #5851

Merged
merged 2 commits into from
Feb 9, 2024
Merged

[frontend] restrict entity_type filter options to Containers in the Analyses tab (5850) #5851

merged 2 commits into from
Feb 9, 2024

Conversation

Archidoit
Copy link
Member

issue: #5850

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Feb 7, 2024
@Archidoit Archidoit self-assigned this Feb 7, 2024
@Archidoit Archidoit linked an issue Feb 7, 2024 that may be closed by this pull request
In the analyses section of an entity, entity types filter should be limited to containers #5850
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1ab71c) 64.72% compared to head (82541ec) 64.73%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5851   +/-   ##
=======================================
  Coverage   64.72%   64.73%           
=======================================
  Files         528      528           
  Lines       61991    61991           
  Branches     4947     4949    +2     
=======================================
+ Hits        40126    40131    +5     
+ Misses      21865    21860    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec self-requested a review February 8, 2024 09:27
@JeremyCloarec
Copy link
Contributor

The Opinion and ObservedData container types are missing from the list

image

@Archidoit
Copy link
Member Author

Archidoit commented Feb 8, 2024 •
edited

The Opinion and ObservedData container types are missing from the list

image

--> FIXED

@Archidoit Archidoit merged commit 50613bb into master Feb 9, 2024
8 checks passed
@Archidoit Archidoit deleted the issue/5850 branch February 9, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyCloarec JeremyCloarec JeremyCloarec approved these changes

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the analyses section of an entity, entity types filter should be limited to containers
2 participants
@Archidoit @JeremyCloarec