Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] User can't access authors list to edit entity (#issue/5848) #5862

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • I removed the query "isUser" on Identity Search component query. The only usage of "isUser" attribute is present in Individual component for edition check but it was call on his own query so I don't know the use of the "isUser" attribute call in the Identity Search Component. There was a precise purpose for this call @SamuelHassine or I can remove it ?

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f30541) 64.72% compared to head (03f47ae) 64.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5862   +/-   ##
=======================================
  Coverage   64.72%   64.73%           
=======================================
  Files         528      528           
  Lines       61991    61991           
  Branches     4948     4949    +1     
=======================================
+ Hits        40126    40131    +5     
+ Misses      21865    21860    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit d13bb84 into master Feb 8, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5848 branch February 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants