Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fixed remaining links from old /dashboard/data/connectors address to new /dashboard/data/ingestion/connectors #5869

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

JeremyCloarec
Copy link
Contributor

Proposed changes

Some links to the old /dashboard/data/connectors endpoint were remaining. I changed it to the new /dashboard/data/ingestion/connectors address

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

…/dashboard/data/ingestion/connectors address
@JeremyCloarec JeremyCloarec added the filigran team use to identify PR from the Filigran team label Feb 8, 2024
@JeremyCloarec JeremyCloarec changed the title Fixed remaining links from old /dashboard/data/connectors address to new /dashboard/data/ingestion/connectors [frontend] Fixed remaining links from old /dashboard/data/connectors address to new /dashboard/data/ingestion/connectors Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1ab71c) 64.72% compared to head (c72bb0f) 64.73%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5869   +/-   ##
=======================================
  Coverage   64.72%   64.73%           
=======================================
  Files         528      528           
  Lines       61991    61991           
  Branches     4947     4949    +2     
=======================================
+ Hits        40126    40131    +5     
+ Misses      21865    21860    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec JeremyCloarec merged commit 8a3ed3b into master Feb 9, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5868 branch February 13, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on a connector on the Data / Import page opens a blank page
2 participants