-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] Organizations types to be in the vocabularies (#3470) #5876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frapuks
changed the title
Issue/3470
[frontend] Organizations types to be in the vocabularies (#3470)
Feb 9, 2024
frapuks
changed the title
[frontend] Organizations types to be in the vocabularies (#3470)
[backend/frontend] Organizations types to be in the vocabularies (#3470)
Feb 9, 2024
frapuks
force-pushed
the
issue/3470
branch
2 times, most recently
from
February 13, 2024 10:08
0058b97
to
7a79f6c
Compare
...i-platform/opencti-graphql/src/migrations/1707207977998-vocabulary-add-organization-types.js
Outdated
Show resolved
Hide resolved
...latform/opencti-front/src/private/components/entities/organizations/OrganizationCreation.tsx
Show resolved
Hide resolved
frapuks
force-pushed
the
issue/3470
branch
2 times, most recently
from
February 14, 2024 13:04
3a7ba30
to
9a15ac8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5876 +/- ##
==========================================
+ Coverage 65.44% 65.47% +0.02%
==========================================
Files 539 539
Lines 63058 63089 +31
Branches 5050 5051 +1
==========================================
+ Hits 41271 41305 +34
+ Misses 21787 21784 -3 ☔ View full report in Codecov by Sentry. |
.../opencti-front/src/private/components/entities/organizations/OrganizationEditionOverview.tsx
Outdated
Show resolved
Hide resolved
Tested locally, all good ✅ |
SouadHadjiat
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
Please pay particular attention to the fact that I've modified the counters to pass the tests