Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Organizations types to be in the vocabularies (#3470) #5876

Merged
merged 16 commits into from
Feb 15, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Feb 9, 2024

Proposed changes

  • Add Vocabulary for Organization type (Possibility to create, update or delete any type)
  • Replace Field with OpenVocabField
  • Remove type translate
  • Display "unknown" in place of "other" for Organization overview without type
  • Add neccessary for database initialisation and migration
  • Allow define default value for organization type

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Please pay particular attention to the fact that I've modified the counters to pass the tests

@frapuks frapuks changed the title Issue/3470 [frontend] Organizations types to be in the vocabularies (#3470) Feb 9, 2024
@frapuks frapuks changed the title [frontend] Organizations types to be in the vocabularies (#3470) [backend/frontend] Organizations types to be in the vocabularies (#3470) Feb 9, 2024
@frapuks frapuks force-pushed the issue/3470 branch 2 times, most recently from 0058b97 to 7a79f6c Compare February 13, 2024 10:08
@frapuks frapuks force-pushed the issue/3470 branch 2 times, most recently from 3a7ba30 to 9a15ac8 Compare February 14, 2024 13:04
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (108cd2f) 65.44% compared to head (886abc3) 65.47%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5876      +/-   ##
==========================================
+ Coverage   65.44%   65.47%   +0.02%     
==========================================
  Files         539      539              
  Lines       63058    63089      +31     
  Branches     5050     5051       +1     
==========================================
+ Hits        41271    41305      +34     
+ Misses      21787    21784       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks self-assigned this Feb 14, 2024
@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Feb 14, 2024
@SouadHadjiat
Copy link
Member

Tested locally, all good ✅

@frapuks frapuks merged commit 176e5ca into master Feb 15, 2024
8 checks passed
@frapuks frapuks deleted the issue/3470 branch February 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants