Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix attributes to display in csv mapper #5883

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

lndrtrbn
Copy link
Member

@lndrtrbn lndrtrbn commented Feb 9, 2024

Proposed changes

  • Remove some attributes
  • Add missing ref attributes for observables by fixing how they are computed

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

I wrote some tests but there are in an other PR about csv mapper that is not yet merged. But this part will be tested when the other PR will be merged.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (ab8b8af) 65.41% compared to head (f0c7a5c) 65.97%.
Report is 4 commits behind head on master.

Files Patch % Lines
...src/modules/internal/csvMapper/csvMapper-domain.ts 11.76% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5883      +/-   ##
==========================================
+ Coverage   65.41%   65.97%   +0.56%     
==========================================
  Files         532      539       +7     
  Lines       62501    63077     +576     
  Branches     5028     5602     +574     
==========================================
+ Hits        40884    41616     +732     
+ Misses      21617    21461     -156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested 👌 that observables have author, external ref, label, markings, score and location don't have anymore precision

@lndrtrbn lndrtrbn merged commit 49ecb64 into master Feb 14, 2024
8 checks passed
@lndrtrbn lndrtrbn deleted the issue/5838 branch February 14, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants