Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improve deletion for large entities (#5803) #5920

Merged
merged 14 commits into from
Feb 12, 2024

Conversation

richard-julien
Copy link
Member

Unable to delete large entities #5803

  • Improve different parts of the code to prevent event loop blocking
  • Remove publish of the dependencies deletion in the Redis stream as not really required

@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Feb 10, 2024
@richard-julien richard-julien self-assigned this Feb 10, 2024
@richard-julien richard-julien linked an issue Feb 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (50613bb) 64.96% compared to head (0d5a240) 65.04%.
Report is 44 commits behind head on master.

Files Patch % Lines
...ti-platform/opencti-graphql/src/database/engine.js 93.54% 6 Missing ⚠️
...latform/opencti-graphql/src/database/middleware.js 84.37% 5 Missing ⚠️
...cti-platform/opencti-graphql/src/database/utils.js 76.19% 5 Missing ⚠️
...latform/opencti-graphql/src/manager/ruleManager.ts 50.00% 5 Missing ⚠️
...ncti-graphql/src/rules/containerWithRefsBuilder.ts 0.00% 3 Missing ⚠️
...ncti-platform/opencti-graphql/src/types/event.d.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5920      +/-   ##
==========================================
+ Coverage   64.96%   65.04%   +0.07%     
==========================================
  Files         528      528              
  Lines       61999    62013      +14     
  Branches     4967     5003      +36     
==========================================
+ Hits        40279    40337      +58     
+ Misses      21720    21676      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit 6e00167 into master Feb 12, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the oob/improve_deletion branch February 12, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants