Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Broken attack patterns matrix everywhere (#5841) #5937

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

richard-julien
Copy link
Member

See #5841

For now instead of changing the screen loading way, bring back the pagination window to 5000.

  • some adaptation to respect the other options
  • default pagination to 500 when nothing is specified.

@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Feb 13, 2024
@richard-julien richard-julien self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6e00167) 64.99% compared to head (5a83fd3) 66.25%.
Report is 9 commits behind head on master.

Files Patch % Lines
...i-platform/opencti-graphql/src/config/providers.js 0.00% 1 Missing ⚠️
...ti-platform/opencti-graphql/src/database/engine.js 90.90% 1 Missing ⚠️
...orm/opencti-graphql/src/domain/stixRelationship.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5937      +/-   ##
==========================================
+ Coverage   64.99%   66.25%   +1.25%     
==========================================
  Files         528      541      +13     
  Lines       62005    63249    +1244     
  Branches     4967     5728     +761     
==========================================
+ Hits        40302    41904    +1602     
+ Misses      21703    21345     -358     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also modify the other usage of first || ES_MAX_PAGINATION in the app to use the new DEFAULT const instead?

  • engine.js line 2546, 2601,
  • domain/container.js line 56
  • elasticSearch-test.js line 397, 414, 474, 537, 554

@richard-julien richard-julien merged commit dc544b7 into master Feb 13, 2024
8 checks passed
@richard-julien richard-julien deleted the issue/5841 branch February 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants