Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix reverse relation (#5836) #5942

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Feb 13, 2024

Proposed changes

  • Relation between Case and task is reversed and wasn't called correctly in the back

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact marked this pull request as ready for review February 13, 2024 16:19
@marieflorescontact marieflorescontact self-assigned this Feb 13, 2024
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Feb 13, 2024
@marieflorescontact marieflorescontact changed the title [frontend] Add updater in CaseTasksLines + console.log [backend] fix reverse relation (#5836) Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9be46c3) 65.02% compared to head (c6a6bef) 66.19%.
Report is 8 commits behind head on master.

Files Patch % Lines
...rm/opencti-graphql/src/modules/task/task-domain.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5942      +/-   ##
==========================================
+ Coverage   65.02%   66.19%   +1.16%     
==========================================
  Files         528      534       +6     
  Lines       62005    62703     +698     
  Branches     4967     5677     +710     
==========================================
+ Hits        40318    41505    +1187     
+ Misses      21687    21198     -489     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact merged commit 784d9ba into master Feb 14, 2024
8 checks passed
@marieflorescontact marieflorescontact deleted the issue/5836 branch February 14, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants