[backend] Fixed issue with skip char line parameter in csv mapper (#5764) #5962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The issue related to this PR mentioned a parsing error when parsing a csv file with the skip char line character at the start of a csv field line.
The error came from the fact that we were trying to skip the lines after the parse was done, but the csv couldn't be parsed because it wasn't recognized as a proper csv file in the raw parser.
I moved the handling of the skip line char to the native parser, using the comment and comment_no_infix options.
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...