Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] fix filters representation when filters with regardingOf (4974) #5975

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[frontend] fix filters representation when filters with regardingOf (4974) #5975

merged 1 commit into from
Feb 15, 2024

Conversation

Archidoit
Copy link
Member

issue: #5974

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Feb 15, 2024
@Archidoit Archidoit self-assigned this Feb 15, 2024
@Archidoit Archidoit linked an issue Feb 15, 2024 that may be closed by this pull request
Display is broken when having regardingOf filter with label filter or Author #5974
Closed
@jpkha jpkha self-requested a review February 15, 2024 09:33
@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024 •
edited

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (49ecb64) 65.44% compared to head (48c5f94) 65.84%.
Report is 8 commits behind head on master.

Files Patch % Lines
...cti-graphql/src/utils/filtering/filtering-utils.ts 81.81% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5975      +/-   ##
==========================================
+ Coverage   65.44%   65.84%   +0.40%     
==========================================
  Files         539      539              
  Lines       63051    63062      +11     
  Branches     5052     5521     +469     
==========================================
+ Hits        41264    41525     +261     
+ Misses      21787    21537     -250

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit merged commit 108cd2f into master Feb 15, 2024
8 checks passed
@Archidoit Archidoit deleted the issue/5974 branch February 15, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkha jpkha jpkha approved these changes

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display is broken when having regardingOf filter with label filter or Author
2 participants
@Archidoit @jpkha