Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Align Nested Object panel with other in the platform (#4931) #5978

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • I Align the Nested Object Panel in Observables Knowledge with the other in the platform (see screenshot)

From this :
Capture d'écran 2024-02-15 115416

To this :
Capture d'écran 2024-02-15 115956

Related issues

@SarahBocognano SarahBocognano self-assigned this Feb 15, 2024
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e7eadf) 65.44% compared to head (f387b96) 67.22%.
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5978      +/-   ##
==========================================
+ Coverage   65.44%   67.22%   +1.78%     
==========================================
  Files         539      539              
  Lines       63059    63533     +474     
  Branches     5051     6178    +1127     
==========================================
+ Hits        41271    42713    +1442     
+ Misses      21788    20820     -968     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member

Behavior tested and ok 👍

@SarahBocognano
Copy link
Member Author

Update : PR comments resolved

@SarahBocognano SarahBocognano changed the title [frontend] Align Nested Object panel with other in the platform WIP (#4931) [frontend] Align Nested Object panel with other in the platform (#4931) Feb 16, 2024
@SarahBocognano SarahBocognano merged commit 5bc9d38 into master Feb 16, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/4931 branch February 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants