Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] remove column 'source' from task errors (#5885) #5987

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Feb 15, 2024

source is not not queried, not in schema, so always empty

Proposed changes

  • do not show the source column, until we have a proper solution to provide it

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

* not queried, not in schema, so always empty
@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Feb 15, 2024
@labo-flg labo-flg self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57e3a4b) 65.46% compared to head (707aacb) 66.02%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5987      +/-   ##
==========================================
+ Coverage   65.46%   66.02%   +0.56%     
==========================================
  Files         539      539              
  Lines       63094    63252     +158     
  Branches     5050     5454     +404     
==========================================
+ Hits        41302    41765     +463     
+ Misses      21792    21487     -305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit f85bd5b into master Feb 15, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5885 branch February 15, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background tasks errors never have a source info
3 participants