Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix malware analyses unknown display #6011

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Feb 16, 2024

Closes #6010

@Kedae Kedae linked an issue Feb 16, 2024 that may be closed by this pull request
@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Feb 16, 2024
@Kedae Kedae requested a review from Archidoit February 16, 2024 15:17
@@ -394,6 +394,7 @@ export const defaultValue = (n, fallback = 'Unknown') => {
|| n.attribute_abstract
|| n.opinion
|| n.value
|| n.product
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's result_name that we want to display for malware analyses

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, missed that. I assumed that the spread on the query was correct 😅
I'll fix that

@Archidoit
Copy link
Member

we should rather add ...on MalwareAnalyses {result_name} in the stix core object query of useSearchEntities.tsx

Copy link
Member

@Archidoit Archidoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

display the malware analyses result_name, not its product

@Archidoit
Copy link
Member

Archidoit commented Feb 16, 2024

malware analyses backend representative is not correct (display the id instead of the result_name) :
image

--> should add the malware analyses case in extractEntityRepresentativeName() of entity-representative.js

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a10e06b) 65.69% compared to head (f4a432e) 65.68%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6011      +/-   ##
==========================================
- Coverage   65.69%   65.68%   -0.01%     
==========================================
  Files         539      539              
  Lines       63534    63536       +2     
  Branches     5131     5131              
==========================================
- Hits        41737    41734       -3     
- Misses      21797    21802       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit 0dc8df9 into master Feb 16, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6010 branch February 16, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malware analyses displayed as Unknown in filters list
3 participants