-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Fix malware analyses unknown display #6011
Conversation
@@ -394,6 +394,7 @@ export const defaultValue = (n, fallback = 'Unknown') => { | |||
|| n.attribute_abstract | |||
|| n.opinion | |||
|| n.value | |||
|| n.product |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's result_name that we want to display for malware analyses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, missed that. I assumed that the spread on the query was correct 😅
I'll fix that
we should rather add ...on MalwareAnalyses {result_name} in the stix core object query of useSearchEntities.tsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display the malware analyses result_name, not its product
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6011 +/- ##
==========================================
- Coverage 65.69% 65.68% -0.01%
==========================================
Files 539 539
Lines 63534 63536 +2
Branches 5131 5131
==========================================
- Hits 41737 41734 -3
- Misses 21797 21802 +5 ☔ View full report in Codecov by Sentry. |
Closes #6010