Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improve batch loading error control and deletion capabilities #6029

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

richard-julien
Copy link
Member

Improve batch loading error control and deletion capabilities.

  • Throw unsupported error if batch loading on rel cant find some ideas
  • Improve deletions replay in case of errors

@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Feb 16, 2024
@richard-julien richard-julien added this to the Release 6.0.0 milestone Feb 16, 2024
@richard-julien richard-julien self-assigned this Feb 16, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8575ee1) 65.69% compared to head (780fcaf) 65.68%.
Report is 7 commits behind head on master.

Files Patch % Lines
...tform/opencti-graphql/src/domain/stixCoreObject.js 46.66% 8 Missing ⚠️
...ti-platform/opencti-graphql/src/database/engine.js 60.00% 2 Missing ⚠️
...latform/opencti-graphql/src/database/middleware.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6029      +/-   ##
==========================================
- Coverage   65.69%   65.68%   -0.01%     
==========================================
  Files         539      539              
  Lines       63551    63570      +19     
  Branches     5125     5136      +11     
==========================================
+ Hits        41748    41756       +8     
- Misses      21803    21814      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit dbec2df into master Feb 17, 2024
10 checks passed
@SamuelHassine SamuelHassine deleted the oob/better_deletion branch February 17, 2024 08:09
@SamuelHassine SamuelHassine removed this from the Release 6.0.0 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants