Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] In Dashboard Network Traffic Attribute Fields Returning Nothing (#5473) #6039

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

SarahBocognano
Copy link
Member

@SarahBocognano SarahBocognano commented Feb 19, 2024

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (888a5e0) 65.70% compared to head (699b6c3) 65.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6039   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files         539      539           
  Lines       63482    63482           
  Branches     5129     5129           
=======================================
+ Hits        41711    41712    +1     
+ Misses      21771    21770    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano self-assigned this Feb 19, 2024
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Feb 19, 2024
Copy link
Member

@SouadHadjiat SouadHadjiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works ✅👏

Not sure about the relevance of the circle icon displayed in the widget, but it's more about the whole widget UI, not related to this bug.

image

@Kedae
Copy link
Member

Kedae commented Feb 20, 2024

Tested locally and it works ✅👏

Not sure about the relevance of the circle icon displayed in the widget, but it's more about the whole widget UI, not related to this bug.

image

The circle was to prevent a '?' icon, but we will see in the future about that

@Kedae Kedae merged commit ae261c1 into master Feb 20, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/5473 branch February 23, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants