Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix names truncated when exporting a Radar widget as CSV(#5969) #6040

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Feb 19, 2024

Proposed changes

  • [frontend] delete formatter to fix names truncated
  • [frontend] add the mitre id as prefix to StixRelationShipsHorizontalBars to fix inconsistent labelling in charts

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CelineSebe CelineSebe linked an issue Feb 19, 2024 that may be closed by this pull request
@CelineSebe CelineSebe self-assigned this Feb 19, 2024
@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Feb 19, 2024
@CelineSebe CelineSebe marked this pull request as draft February 19, 2024 16:25
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (888a5e0) 65.70% compared to head (918e84a) 65.72%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6040      +/-   ##
==========================================
+ Coverage   65.70%   65.72%   +0.02%     
==========================================
  Files         539      539              
  Lines       63482    63492      +10     
  Branches     5129     5165      +36     
==========================================
+ Hits        41711    41731      +20     
+ Misses      21771    21761      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe marked this pull request as ready for review February 20, 2024 14:46
@CelineSebe CelineSebe merged commit 62f3386 into master Feb 20, 2024
8 checks passed
@CelineSebe CelineSebe deleted the issue/5969 branch February 20, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names are truncated when exporting a Radar widget as CSV
2 participants