Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] use of istanbul plugin dynamic #6055

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

jpkha
Copy link
Member

@jpkha jpkha commented Feb 20, 2024

use of istanbul plugin dynamic.
By default do not use the plugin as we are just using for the coverage.

@jpkha jpkha added the filigran team use to identify PR from the Filigran team label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae261c1) 65.72% compared to head (e3e382e) 66.70%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6055      +/-   ##
==========================================
+ Coverage   65.72%   66.70%   +0.98%     
==========================================
  Files         539      541       +2     
  Lines       63492    64295     +803     
  Branches     5132     5715     +583     
==========================================
+ Hits        41729    42890    +1161     
+ Misses      21763    21405     -358     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg
Copy link
Member

Thanks ! Shall we set this env variable in the package.json scripts that run the tests then ?

@labo-flg labo-flg self-requested a review February 21, 2024 07:53
@Kedae Kedae merged commit 56b6bb2 into master Feb 21, 2024
8 checks passed
@jpkha jpkha deleted the issue/use-dynamically-istanbul branch February 21, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants