Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Fix malware analyses pagination error on submission date if null (#6054) #6058

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Feb 20, 2024

Proposed changes

  • use missing: 0 for dates fixes the issue with sorting
  • set submitted to nullable in malware creation and edition
  • add test

Related issues

To reproduce the issue locally, you need to create more than 25 malware analyses with at least one without a submitted date. You can also export malware analyses from testing platform and import them on your local platform.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62f3386) 65.94% compared to head (2bf9b53) 65.95%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6058   +/-   ##
=======================================
  Coverage   65.94%   65.95%           
=======================================
  Files         541      541           
  Lines       64286    64290    +4     
  Branches     5199     5201    +2     
=======================================
+ Hits        42395    42404    +9     
+ Misses      21891    21886    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Feb 21, 2024
@SouadHadjiat SouadHadjiat marked this pull request as ready for review February 21, 2024 09:54
@SouadHadjiat SouadHadjiat linked an issue Feb 21, 2024 that may be closed by this pull request
@jpkha jpkha self-assigned this Feb 22, 2024
@SouadHadjiat SouadHadjiat merged commit 6488f35 into master Feb 22, 2024
8 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/6054 branch February 22, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malware analyses pagination error on submission date if null
2 participants