[backend/frontend] entity_type filter available for abstract types #6064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archidoit
added
filigran team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6064 +/- ##
=======================================
Coverage 65.94% 65.95%
=======================================
Files 541 541
Lines 64286 64289 +3
Branches 5199 5202 +3
=======================================
+ Hits 42395 42403 +8
+ Misses 21891 21886 -5 ☔ View full report in Codecov by Sentry. |
|
Can we have a small e2e test for that ? :) |
|
@Kedae I added a backend test since the problem is only from the back, but I can also add an e2e :) |
Archidoit
force-pushed
the
issue/4949-2
branch
2 times, most recently
from
59035d5
to
58f6849
Compare
Archidoit
force-pushed
the
issue/4949-2
branch
from
58f6849
to
02e2420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue (on testing only) : entity_type filter not available in Data>Entities, Observations>Observables, Global Search