[frontend/test] Update settings relay management and add testing #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kedae
force-pushed
the
issue/improveSettingsRelay
branch
from
df86790
to
1764a64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6066 +/- ##
==========================================
+ Coverage 65.94% 66.23% +0.28%
==========================================
Files 541 541
Lines 64286 64294 +8
Branches 5199 5376 +177
==========================================
+ Hits 42393 42583 +190
+ Misses 21893 21711 -182 ☔ View full report in Codecov by Sentry. |
|
Error on EE e2e test : |
I haven't modify this test and the PR is green, I think your local is at fault :D --> oww @Kedae yes sorry |
Archidoit
approved these changes
Feb 23, 2024
SamuelHassine
force-pushed
the
master
branch
2 times, most recently
from
cdc32a6
to
6368e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.