Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Based on relationship should inherit markings & restrictions when created from Indicators or observables (#6068) #6069

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Feb 21, 2024

Proposed changes

  • make sure we generate observables / indicators from indicators / observables with the same markings and organization sharing, either from API or in playbooks.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 4.16667% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 66.69%. Comparing base (fa68be5) to head (30f029b).
Report is 3 commits behind head on master.

Files Patch % Lines
...raphql/src/modules/playbook/playbook-components.ts 0.00% 25 Missing ⚠️
...-graphql/src/modules/indicator/indicator-domain.ts 5.26% 18 Missing ⚠️
.../opencti-graphql/src/domain/stixCyberObservable.js 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6069      +/-   ##
==========================================
- Coverage   66.73%   66.69%   -0.05%     
==========================================
  Files         540      540              
  Lines       64180    64219      +39     
  Branches     5241     5241              
==========================================
- Hits        42832    42830       -2     
- Misses      21348    21389      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested :

  • Create an indicator => marking label and sharing ok
  • Create an observable =>marking label and sharing ok
  • Bulk actions =>marking label and sharing ok
  • Playbooks:=>marking label and sharing ok

@SouadHadjiat SouadHadjiat merged commit b76347f into master Feb 27, 2024
8 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/6068 branch February 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Based on relationship should inherit markings & restrictions when created from Indicators or observables
2 participants